Bug 215995

Summary:

Update generateEmptyHeaderAndCpp in generate-bindings.pl to use proper English and use an #error to catch accidental compilation

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Bindings

Assignee:

Sam Weinig <sam>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

cdumez, darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sam Weinig 2020-08-30 18:25:19 PDT

As noted by Darin in https://bugs.webkit.org/show_bug.cgi?id=215992, we should update generateEmptyHeaderAndCpp in generate-bindings.pl to use proper English and use an #error to catch accidental compilation.

Comment 1 Sam Weinig 2020-08-30 19:15:38 PDT

Created attachment 407584 [details]
Patch

Comment 2 Darin Adler 2020-08-31 09:29:19 PDT

Comment on attachment 407584 [details]
Patch

Looks ike these empty headers and file are indeed compiled, despite the comment saying they "must not".

Comment 3 Sam Weinig 2020-08-31 10:35:53 PDT

(In reply to Darin Adler from comment #2)
> Comment on attachment 407584 [details]
> Patch
> 
> Looks ike these empty headers and file are indeed compiled, despite the
> comment saying they "must not".

Very much so :).

Comment 4 Radar WebKit Bug Importer 2020-09-06 18:26:18 PDT

<rdar://problem/68439122>

Comment 5 Sam Weinig 2020-09-14 14:10:35 PDT

I handled this in another bug.