| Summary: | EnabledBySetting extended attributes on a partial interface do not get merged with EnabledBySetting extended attributes on properties of that partial interface | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | Bindings | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, darin, esprehn+autocc, ews-watchlist, joepeck, kondapallykalyan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 215981 | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2020-08-30 16:01:12 PDT
Created attachment 407579 [details]
Patch
Comment on attachment 407579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407579&action=review > Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp:5 > + JSTestEnabledBySettingSupplemental.cpp at every build. This file must not be tried to compile. Not new or part of this patch, but just noticed: 1) We might want to reword "This file must not be tried to compile." since that's not English. 2) If we don’t want people to compile something normally we’d put #error in it. Committed r266339: <https://trac.webkit.org/changeset/266339> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407579 [details]. (In reply to Darin Adler from comment #2) > Comment on attachment 407579 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407579&action=review > > > Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp:5 > > + JSTestEnabledBySettingSupplemental.cpp at every build. This file must not be tried to compile. > > Not new or part of this patch, but just noticed: > > 1) We might want to reword "This file must not be tried to compile." since > that's not English. > > 2) If we don’t want people to compile something normally we’d put #error in > it. Will do this with https://bugs.webkit.org/show_bug.cgi?id=215995. |