| Summary: | Implement WEBGL_compressed_texture_s3tc_srgb extension | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||
| Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 214640, 215844 | ||||||||
| Attachments: |
|
||||||||
|
Description
James Darpinian
2020-08-28 23:07:44 PDT
Created attachment 407531 [details]
Patch
Created attachment 407534 [details]
rebase
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE This fixes the Unity Tanks demo (see bug 215844) in WebGL 1. The demo assumes sRGB is available if S3TC is. (The demo is still broken in WebGL 2 due to another as yet unidentified bug.) Committed r266364: <https://trac.webkit.org/changeset/266364> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407534 [details]. Comment on attachment 407534 [details] rebase View in context: https://bugs.webkit.org/attachment.cgi?id=407534&action=review > Source/WebCore/ChangeLog:8 > + Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html In some sense, it is indeed, but the test passed before the change, and still passes after it. Yes, this is a problem common to all the extension tests. They trivially pass if the extension is not supported. Bug 217005 covers writing a separate test to check that the set of supported extensions is correct, but it's nontrivial because the result depends on the GPU hardware, not just the platform. |