Bug 215973

Summary: Implement WEBGL_compressed_texture_s3tc_srgb extension
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: WebGLAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 214640, 215844    
Attachments:
Description Flags
Patch
none
rebase none

James Darpinian
Reported 2020-08-28 23:07:44 PDT
Implement WEBGL_compressed_texture_s3tc_srgb extension
Attachments
Patch (31.32 KB, patch)
2020-08-28 23:38 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
rebase (31.29 KB, patch)
2020-08-28 23:47 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-08-28 23:38:24 PDT
Created attachment 407531 [details] Patch
James Darpinian
Comment 2 2020-08-28 23:47:12 PDT
Created attachment 407534 [details] rebase
EWS Watchlist
Comment 3 2020-08-28 23:48:07 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
James Darpinian
Comment 4 2020-08-29 00:00:20 PDT
This fixes the Unity Tanks demo (see bug 215844) in WebGL 1. The demo assumes sRGB is available if S3TC is. (The demo is still broken in WebGL 2 due to another as yet unidentified bug.)
EWS
Comment 5 2020-08-31 11:59:13 PDT
Committed r266364: <https://trac.webkit.org/changeset/266364> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407534 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-31 12:00:16 PDT
<rdar://problem/68090510>
Alexey Proskuryakov
Comment 7 2020-10-17 12:19:03 PDT
Comment on attachment 407534 [details] rebase View in context: https://bugs.webkit.org/attachment.cgi?id=407534&action=review > Source/WebCore/ChangeLog:8 > + Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html In some sense, it is indeed, but the test passed before the change, and still passes after it.
James Darpinian
Comment 8 2020-10-17 20:22:45 PDT
Yes, this is a problem common to all the extension tests. They trivially pass if the extension is not supported. Bug 217005 covers writing a separate test to check that the set of supported extensions is correct, but it's nontrivial because the result depends on the GPU hardware, not just the platform.
Note You need to log in before you can comment on or make changes to this bug.