| Summary: | [ews] Notify bot watchers about pre-existing and flaky test failures for API tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=215948 https://bugs.webkit.org/show_bug.cgi?id=207475 |
||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-08-28 13:34:35 PDT
Created attachment 407957 [details]
Patch
Comment on attachment 407957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407957&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2606 > + def send_email_for_flaky_failure(self, test_name): I'm find with this as-is, but it does seem like we're duplicating quite a bit of code for layout test emails. Seems like we might want a base "AnalyzeTestResults" step with a "send_email_for_flaky_failure(self, test_name):" function that pulls from a "suite" variable Yeah, will do that in a separate patch. Committed r266626: <https://trac.webkit.org/changeset/266626> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407957 [details]. |