| Summary: | Resync web-platform-tests/webaudio from upstream | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | clopez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, tsavell, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 212611 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2020-08-28 10:46:17 PDT
Created attachment 407485 [details]
Patch
Comment on attachment 407485 [details]
Patch
rs=me
Committed r266289: <https://trac.webkit.org/changeset/266289> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407485 [details]. After the resync in r266289 this test: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum.html began flakily failing very often due to an additional Console Message: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebaudio%2Fthe-audio-api%2Fthe-analysernode-interface%2Ftest-analyser-minimum.html Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: Error: assert_true: silent input process -Infinity in decibel bins expected true got false CONSOLE MESSAGE: Error: assert_true: silent input process -Infinity in decibel bins expected true got false FAIL Test AnalyserNode when the input is silent Error: assert_true: silent input process -Infinity in decibel bins expected true got false (In reply to Truitt Savell from comment #5) > After the resync in r266289 this test: > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode- > interface/test-analyser-minimum.html > > began flakily failing very often due to an additional Console Message: > https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb- > platform-tests%2Fwebaudio%2Fthe-audio-api%2Fthe-analysernode- > interface%2Ftest-analyser-minimum.html > > Diff: > --- > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/ > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode- > interface/test-analyser-minimum-expected.txt > +++ > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/ > imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode- > interface/test-analyser-minimum-actual.txt > @@ -1,3 +1,4 @@ > +CONSOLE MESSAGE: Error: assert_true: silent input process -Infinity in > decibel bins expected true got false > CONSOLE MESSAGE: Error: assert_true: silent input process -Infinity in > decibel bins expected true got false > > FAIL Test AnalyserNode when the input is silent Error: assert_true: silent > input process -Infinity in decibel bins expected true got false <https://trac.webkit.org/changeset/266366> should address this. |