Bug 215932

Summary: [Cocoa] Disable sniffing for WebSocket handshakes
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2020-08-28 09:48:26 PDT 
[Cocoa] Disable sniffing for WebSocket handshakes
Comment 1 youenn fablet 2020-08-28 09:51:21 PDT 
Created attachment 407477 [details]
Patch
Comment 2 Darin Adler 2020-08-28 10:08:09 PDT 
Comment on attachment 407477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407477&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1607
> +    // FIXME: CFNetwork should probably disable sniffing by default for WebSocket handshakes.

I don’t think a suggested change to CFNetwork should be covered by a FIXME in WebKit source code.
Comment 3 youenn fablet 2020-08-31 00:22:37 PDT 
Created attachment 407591 [details]
Patch for landing
Comment 4 EWS 2020-08-31 01:58:38 PDT 
Committed r266347: <https://trac.webkit.org/changeset/266347>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407591 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-31 01:59:13 PDT 
<rdar://problem/68060631>