Bug 215929

Summary: [ macOS iOS ] compositing/video/poster.html is a flaky failure
Product: WebKit Reporter: Hector Lopez <hector_i_lopez>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: ahmad.saleem792, eric.carlson, jer.noble, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206678
https://bugs.webkit.org/show_bug.cgi?id=206916
Attachments:
Description Flags
Expected image
none
Actual image
none
Diff image none

Description Hector Lopez 2020-08-28 08:58:39 PDT 
compositing/video/poster.html

Test is a flaky failure according to history on macOS and iOS. First occurrence of failure on macOS is at r250985. There was no failures on macOS between r255329 and r261664 but there were a group of crashes and timeouts in this period which may be unrelated. First occurrence of failure on iOS is at r261698.

Possible related cases:

https://bugs.webkit.org/show_bug.cgi?id=206678

https://bugs.webkit.org/show_bug.cgi?id=206916

History:
https://results.webkit.org/?suite=layout-tests&test=compositing%2Fvideo%2Fposter.html&platform=mac&platform=ios&limit=50000

Diff:
https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Release%20WK2%20(Tests)/r266275%20(6433)/compositing/video/poster-diffs.html

or see attachments
Comment 1 Radar WebKit Bug Importer 2020-08-28 08:59:02 PDT 
<rdar://problem/67943379>
Comment 2 Hector Lopez 2020-08-28 09:00:56 PDT 
Created attachment 407472 [details]
Expected image
Comment 3 Hector Lopez 2020-08-28 09:01:35 PDT 
Created attachment 407473 [details]
Actual image
Comment 4 Hector Lopez 2020-08-28 09:01:55 PDT 
Created attachment 407474 [details]
Diff image
Comment 5 Hector Lopez 2020-08-28 09:10:15 PDT 
Test expectation while investigated:

https://trac.webkit.org/changeset/266279/webkit

Test expectation for macOS and iOS wk1 already in place.
Comment 6 Ahmad Saleem 2023-12-31 22:44:29 PST 
If I understand the images correctly, it seems that we fail to load 'poster' and we have different aspect ratio. So it has two issue: 1) Flaky 2) Wrong aspect ratio.

I stumbled across because I was looking into one of Blink commit:

https://chromium.googlesource.com/chromium/blink/+/4553a07a51b9a38011642f5ccd194c1c059f20e6

In which following was modified:

(WebKit function)

https://searchfox.org/wubkat/rev/af9971e796398c1d012ef5df9a09ed580d19bd17/Source/WebCore/rendering/RenderImage.cpp#425

bool RenderImage::shouldDisplayBrokenImageIcon() const
{
    return imageResource().errorOccurred();
}

to

bool RenderImage::shouldDisplayBrokenImageIcon() const
{
    return imageResource().errorOccurred() && !isVideo();
}

and then it will leads to:

https://searchfox.org/wubkat/rev/af9971e796398c1d012ef5df9a09ed580d19bd17/Source/WebCore/rendering/RenderImage.cpp#889

to maintain aspect ratio.

Just documenting here.