| Summary: | AudioParam does not need to store its values as double | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 212611 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2020-08-27 15:36:17 PDT
Created attachment 407428 [details]
Patch
Comment on attachment 407428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407428&action=review > Source/WebCore/Modules/webaudio/AudioParam.h:85 > + unsigned units() const { return 0; } Maybe change to a static member function for now since it just returns a constant; eventually delete it. Created attachment 407434 [details]
Patch
Created attachment 407435 [details]
Patch
Comment on attachment 407435 [details] Patch Clearing flags on attachment: 407435 Committed r266263: <https://trac.webkit.org/changeset/266263> All reviewed patches have been landed. Closing bug. |