| Summary: | [webkitpy] Use webkitcorepy's auto installer for moz* packages | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=214950 https://bugs.webkit.org/show_bug.cgi?id=216879 |
||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jonathan Bedard
2020-08-27 09:03:18 PDT
Created attachment 407407 [details]
Patch
Created attachment 409309 [details]
Patch
Created attachment 409311 [details]
Patch
Comment on attachment 409309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409309&action=review rs=me > Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:-31 > -import webkitpy.thirdparty.autoinstalled.mozlog These imports aren't required anymore? (In reply to Aakash Jain from comment #5) > Comment on attachment 409309 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409309&action=review > > rs=me > > > Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:-31 > > -import webkitpy.thirdparty.autoinstalled.mozlog > > These imports aren't required anymore? They aren't valid any more. The old autoinstaller required that you preface an autoinstalled library with 'webkitpy.thirdparty.autoinstalled' to trigger the auto-instillation. The new one will pick up any import of the library. That means that in this case, "from mozlog import structuredlog" will install mozlog for us. Created attachment 409317 [details]
Patch for landing
Committed r267368: <https://trac.webkit.org/changeset/267368> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409317 [details]. |