Bug 215885

Summary: [Cygwin] The kill-old-processes script should terminate every python process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: NEW    
Severity: Normal CC: aakash_jain, bfulgham, ews-watchlist, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pvollan: review?

Per Arne Vollan
Reported 2020-08-27 08:09:24 PDT
In order to avoid hanging python processes listening to http server ports, the kill-old-processes script should terminate every python process, except for the python process running the script.
Attachments
Patch (1.90 KB, patch)
2020-08-27 08:12 PDT, Per Arne Vollan 		pvollan: review?
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-08-27 08:12:09 PDT
Created attachment 407399 [details] Patch
Jonathan Bedard
Comment 2 2020-08-27 08:27:40 PDT
Comment on attachment 407399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407399&action=review > Tools/BuildSlaveSupport/kill-old-processes:139 > + cmd = "ps af | grep -E '.+/python' | grep -v grep | grep -v " + str(os.getpid()) + " | awk '{print $2}' | xargs kill -9" Isn't builedbot also a python process?
Per Arne Vollan
Comment 3 2020-08-27 08:30:37 PDT
(In reply to Jonathan Bedard from comment #2) > Comment on attachment 407399 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407399&action=review > > > Tools/BuildSlaveSupport/kill-old-processes:139 > > + cmd = "ps af | grep -E '.+/python' | grep -v grep | grep -v " + str(os.getpid()) + " | awk '{print $2}' | xargs kill -9" > > Isn't builedbot also a python process? Ah, that is a good point! It might very well be. In Cygwin, it seems there is no information from ps about what script a python process is running.
Jonathan Bedard
Comment 4 2020-08-27 08:44:12 PDT
(In reply to Per Arne Vollan from comment #3) > (In reply to Jonathan Bedard from comment #2) > > Comment on attachment 407399 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=407399&action=review > > > > > Tools/BuildSlaveSupport/kill-old-processes:139 > > > + cmd = "ps af | grep -E '.+/python' | grep -v grep | grep -v " + str(os.getpid()) + " | awk '{print $2}' | xargs kill -9" > > > > Isn't builedbot also a python process? > > Ah, that is a good point! It might very well be. In Cygwin, it seems there > is no information from ps about what script a python process is running. Wonder if we could preserve only the oldest Python process (which should be buildbot)
Radar WebKit Bug Importer
Comment 5 2020-09-03 08:10:12 PDT
<rdar://problem/68279416>
Note You need to log in before you can comment on or make changes to this bug.