| Summary: | Make ImageDiff before TestWebKitAPI | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | darin, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2020-08-26 12:35:47 PDT
Created attachment 407322 [details]
Patch
Comment on attachment 407322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407322&action=review > Tools/ChangeLog:3 > + Make ImageDiff before TestWebKitAPI Given you are optimizing the sequence, why did you put it after MiniBrowser? > Tools/Makefile:5 > +ifeq (,$(DO_NOT_BUILD_IMAGE_DIFF)) > + MODULES += ImageDiff > +endif Would be nice to have a comment here, since it’s not obvious why we are adding ImageDiff to the middle. Comment on attachment 407322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407322&action=review >> Tools/ChangeLog:3 >> + Make ImageDiff before TestWebKitAPI > > Given you are optimizing the sequence, why did you put it after MiniBrowser? MiniBrowser doesn't take long to build, but you're right. That would be even better! |