Bug 215825

Summary: [Mac,EME] Netflix.com shows HDCP error for all streams
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Jer Noble
Reported 2020-08-25 14:17:41 PDT
[Mac,EME] Netflix.com shows HDCP error for all streams
Attachments
Patch (7.16 KB, patch)
2020-08-25 14:26 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (7.16 KB, patch)
2020-08-25 14:57 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-08-25 14:22:40 PDT
<rdar://problem/66948621>
Jer Noble
Comment 2 2020-08-25 14:26:54 PDT
Created attachment 407231 [details] Patch
Eric Carlson
Comment 3 2020-08-25 14:35:51 PDT
Comment on attachment 407231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407231&action=review > Source/WebCore/ChangeLog:11 > + displayID. This causes AVFoundation to do a "lowest common level of support" rather than a specific display check. s/level of support/level of support/ > Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1388 > +bool CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID(AVContentKeyRequest *request, PlatformDisplayID displayID) const s/AVContentKeyRequest *request/AVContentKeyRequest *request/ > Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1390 > + // willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays will always return "YES" prior s/return "YES" prior/return "YES" prior to/ > Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1400 > + // and to query the HDCP level required by each AVContentKeyRequest, and do the comparison between th two in the s/between th two/between the two/
Peng Liu
Comment 4 2020-08-25 14:43:35 PDT
Comment on attachment 407231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407231&action=review > Source/WebCore/ChangeLog:13 > + AVContentKeyRequest will report that it's output is restricted if any non-HDCP compliant display is attached. s/it's/its
Jer Noble
Comment 5 2020-08-25 14:57:07 PDT
Created attachment 407237 [details] Patch for landing
EWS
Comment 6 2020-08-26 10:57:11 PDT
Committed r266176: <https://trac.webkit.org/changeset/266176> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407237 [details].
Note You need to log in before you can comment on or make changes to this bug.