Bug 215758

Summary: ScrollLatchingState::startedGestureAtScrollLimit() is always false; remove it
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, cmarcelo, darin, ews-watchlist, fred.wang, jamesr, luiz, sam, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Simon Fraser (smfr)
Reported 2020-08-23 11:15:42 PDT
ScrollLatchingState::startedGestureAtScrollLimit() is always false; remove it
Attachments
Patch (6.35 KB, patch)
2020-08-23 11:16 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-08-23 11:16:44 PDT
Created attachment 407076 [details] Patch
Darin Adler
Comment 2 2020-08-23 11:33:29 PDT
Comment on attachment 407076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407076&action=review > Source/WebCore/page/scrolling/ScrollLatchingState.h:59 > + // FIXME: scrollablearea. What does this comment mean? Could you write just a few more words in it?
Simon Fraser (smfr)
Comment 3 2020-08-23 11:34:59 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 407076 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407076&action=review > > > Source/WebCore/page/scrolling/ScrollLatchingState.h:59 > > + // FIXME: scrollablearea. > > What does this comment mean? Could you write just a few more words in it? I'll remove it for this patch.
Radar WebKit Bug Importer
Comment 4 2020-08-30 11:16:36 PDT
<rdar://problem/68034808>
Ahmad Saleem
Comment 5 2023-07-08 16:07:17 PDT
I tried to search for 'startedGestureAtScrollLimit' and 'setStartedGestureAtScrollLimit', which this patch was removing but didn't manage to find it. Also unable to find commit as well (weird). @Simon & @Darin - do we need to keep this open?
Simon Fraser (smfr)
Comment 6 2023-07-10 11:52:39 PDT
This landed in https://commits.webkit.org/228689@main
Note You need to log in before you can comment on or make changes to this bug.