| Summary: | ScrollLatchingState::startedGestureAtScrollLimit() is always false; remove it | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, cmarcelo, darin, ews-watchlist, fred.wang, jamesr, luiz, sam, simon.fraser, tonikitoo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2020-08-23 11:15:42 PDT
Created attachment 407076 [details]
Patch
Comment on attachment 407076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407076&action=review > Source/WebCore/page/scrolling/ScrollLatchingState.h:59 > + // FIXME: scrollablearea. What does this comment mean? Could you write just a few more words in it? (In reply to Darin Adler from comment #2) > Comment on attachment 407076 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407076&action=review > > > Source/WebCore/page/scrolling/ScrollLatchingState.h:59 > > + // FIXME: scrollablearea. > > What does this comment mean? Could you write just a few more words in it? I'll remove it for this patch. I tried to search for 'startedGestureAtScrollLimit' and 'setStartedGestureAtScrollLimit', which this patch was removing but didn't manage to find it. Also unable to find commit as well (weird). @Simon & @Darin - do we need to keep this open? This landed in https://commits.webkit.org/228689@main |