Bug 215742

Summary:

Regression (r265942): Layout-tests are hanging on iOS EWS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-watchlist, glenn, jbedard, ryanhaddad, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=215584

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-08-21 15:43:07 PDT

Layout-tests seems to be hanging (and getting killed by buildbot after 20 minutes) on iOS EWS.

e.g.: https://ews-build.webkit.org/#/builders/24/builds/24138/steps/10/logs/stdio

13:58:29.862 4724 worker/9 starting
13:58:29.873 4724 "xcrun --sdk iphonesimulator --show-sdk-version" took 0.01s
command timed out: 1200 seconds without output running ['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-show-results', '--no-new-test-results', '--clobber-old-results', '--release', '--ios-simulator', '--results-directory', 'layout-test-results', '--debug-rwt-logging', '--exit-after-n-failures', '30', '--skip-failing-tests'], attempting to kill
process killed by signal 9
program finished with exit code -1


Seems to be happening consistently:
https://ews-build.webkit.org/#/builders/24/builds/24140
https://ews-build.webkit.org/#/builders/24/builds/24139
https://ews-build.webkit.org/#/builders/24/builds/24138

Comment 1 Aakash Jain 2020-08-21 15:43:26 PDT

<rdar://problem/67584717>

Comment 2 Aakash Jain 2020-08-21 15:44:30 PDT

It seems to have started in https://ews-build.webkit.org/#/builders/24/builds/24053 (started around Aug 20 8:45am, which was built with r265943)

previously, https://ews-build.webkit.org/#/builders/24/builds/24051 passed successfully.


Seems to be due to https://trac.webkit.org/r265942 which made changes to Timeout and was landed just before the first noticeable failure (Aug 20, 7:33 am).

Comment 3 Jonathan Bedard 2020-08-21 16:35:08 PDT

Something super weird is going on, going to upload a partial revert of https://trac.webkit.org/r265942 (one that doesn't revert the parts that would be conflicts)

Comment 4 Jonathan Bedard 2020-08-21 16:38:55 PDT

Created attachment 407032 [details]
Patch

Comment 5 Aakash Jain 2020-08-21 17:05:45 PDT

Comment on attachment 407032 [details]
Patch

r+ since it seems to fix the issue (layout-tests running in https://ews-build.webkit.org/#/builders/24/builds/24145)

Comment 6 EWS 2020-08-21 17:20:55 PDT

Committed r266020: <https://trac.webkit.org/changeset/266020>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407032 [details].