| Summary: | [Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa platforms, so there's no need to consult it in Cocoa-specific files | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 215685 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Myles C. Maxfield
2020-08-19 20:22:21 PDT
Created attachment 406907 [details]
Patch
Created attachment 406908 [details]
Patch
Comment on attachment 406908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406908&action=review > Source/WebCore/platform/graphics/FontCascadeDescription.cpp:66 > -#if !USE(PLATFORM_SYSTEM_FALLBACK_LIST) > +#if !PLATFORM(COCOA) I feel like any time we change an #if to literally check PLATFORM instead of a feature, it’s a small step backward. Comment on attachment 406908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406908&action=review This isn't for any particular bug, so I should probably hold off on committing it. >> Source/WebCore/platform/graphics/FontCascadeDescription.cpp:66 >> +#if !PLATFORM(COCOA) > > I feel like any time we change an #if to literally check PLATFORM instead of a feature, it’s a small step backward. Yeah, you're right. It might be better to put copies of this function in each of the port-specific versions of FontCascadeDescription.cpp. Created attachment 408071 [details]
Patch for committing
Created attachment 408072 [details]
Patch for committing
Created attachment 408073 [details]
Patch for committing
Tools/Scripts/svn-apply failed to apply attachment 408073 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Committed r266672: <https://trac.webkit.org/changeset/266672> |