Bug 215684

Summary: [Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa platforms, so there's no need to consult it in Cocoa-specific files
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215685    
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch for committing
none
Patch for committing
none
Patch for committing ews-feeder: commit-queue-

Myles C. Maxfield
Reported 2020-08-19 20:22:21 PDT
[Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa platforms, so there's no need to consult it in Cocoa-specific files
Attachments
Patch (13.17 KB, patch)
2020-08-19 20:29 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (14.37 KB, patch)
2020-08-19 20:31 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
Patch for committing (21.15 KB, patch)
2020-09-05 01:19 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (21.14 KB, patch)
2020-09-05 01:20 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (21.13 KB, patch)
2020-09-05 01:24 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-08-19 20:29:27 PDT
Created attachment 406907 [details] Patch
Myles C. Maxfield
Comment 2 2020-08-19 20:31:21 PDT
Created attachment 406908 [details] Patch
Darin Adler
Comment 3 2020-08-19 21:12:08 PDT
Comment on attachment 406908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406908&action=review > Source/WebCore/platform/graphics/FontCascadeDescription.cpp:66 > -#if !USE(PLATFORM_SYSTEM_FALLBACK_LIST) > +#if !PLATFORM(COCOA) I feel like any time we change an #if to literally check PLATFORM instead of a feature, it’s a small step backward.
Myles C. Maxfield
Comment 4 2020-08-19 21:48:02 PDT
Comment on attachment 406908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406908&action=review This isn't for any particular bug, so I should probably hold off on committing it. >> Source/WebCore/platform/graphics/FontCascadeDescription.cpp:66 >> +#if !PLATFORM(COCOA) > > I feel like any time we change an #if to literally check PLATFORM instead of a feature, it’s a small step backward. Yeah, you're right. It might be better to put copies of this function in each of the port-specific versions of FontCascadeDescription.cpp.
Radar WebKit Bug Importer
Comment 5 2020-08-26 20:23:17 PDT
<rdar://problem/67847196>
Myles C. Maxfield
Comment 6 2020-09-05 01:19:22 PDT
Created attachment 408071 [details] Patch for committing
Myles C. Maxfield
Comment 7 2020-09-05 01:20:15 PDT
Created attachment 408072 [details] Patch for committing
Myles C. Maxfield
Comment 8 2020-09-05 01:24:17 PDT
Created attachment 408073 [details] Patch for committing
EWS
Comment 9 2020-09-05 11:11:29 PDT
Tools/Scripts/svn-apply failed to apply attachment 408073 [details] to trunk. Please resolve the conflicts and upload a new patch.
Myles C. Maxfield
Comment 10 2020-09-05 14:34:22 PDT
Committed r266672: <https://trac.webkit.org/changeset/266672>
Note You need to log in before you can comment on or make changes to this bug.