Bug 215669

Summary: AudioBufferSourceNode should use "final" values for playbackRate and detune
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: clark_wang, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-08-19 16:52:45 PDT 
AudioBufferSourceNode should use "final" values for playbackRate and detune to take into account changes to the AudioParamTimeline (for example, when AudioBufferSourceNode.playbackRate.setValueAtTime() is called).
Comment 1 Chris Dumez 2020-08-19 16:54:51 PDT 
Created attachment 406887 [details]
Patch
Comment 2 Eric Carlson 2020-08-20 09:27:20 PDT 
Looks like this is causing lots of asserts in tests.
Comment 3 Chris Dumez 2020-08-20 10:32:39 PDT 
Created attachment 406944 [details]
Patch
Comment 4 Chris Dumez 2020-08-20 15:52:55 PDT 
(In reply to Eric Carlson from comment #2)
> Looks like this is causing lots of asserts in tests.

Yes, turns out you can only call finalValue() from the AudioThread. This is fixed now.
Comment 5 EWS 2020-08-20 16:15:23 PDT 
Committed r265981: <https://trac.webkit.org/changeset/265981>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406944 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-20 16:16:18 PDT 
<rdar://problem/67513315>