Bug 215668

Summary: Fix possible crash when webAnimationsCSSIntegrationEnabled is false
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: AnimationsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, graouts, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2020-08-19 16:13:57 PDT 
Fix possible crash when webAnimationsCSSIntegrationEnabled is false
Comment 1 Simon Fraser (smfr) 2020-08-19 16:16:13 PDT 
Created attachment 406885 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-08-19 16:16:15 PDT 
<rdar://problem/67402003>
Comment 3 Darin Adler 2020-08-19 16:19:17 PDT 
Comment on attachment 406885 [details]
Patch

Too bad we have to do this manually. Encoding and decoding Optional<> handles this correctly automatically, but I guess with pointers it’s ambiguous whether they can be null or not.
Comment 4 Simon Fraser (smfr) 2020-08-19 16:32:32 PDT 
Optional<> would have be easier if the timing-function encoding didn't need special-casing.
Comment 5 EWS 2020-08-19 20:51:31 PDT 
Committed r265932: <https://trac.webkit.org/changeset/265932>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406885 [details].