Bug 215660

Summary: [Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch for landing none

Description Jer Noble 2020-08-19 12:56:27 PDT
[Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode.
Comment 1 Jer Noble 2020-08-19 12:56:59 PDT
<rdar://problem/65263150>
Comment 2 Jer Noble 2020-08-19 13:05:37 PDT
Created attachment 406869 [details]
Patch
Comment 3 Darin Adler 2020-08-19 13:35:27 PDT
Comment on attachment 406869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406869&action=review

> Source/WebKit/ChangeLog:12
> +        The default behavior of NSWindow is to change its -keyViewSelectionDirection to NSSelectingNext when activating
> +        and changing the firstResponder. This causes WKWebView to change it's focus in response to becoming first responder.
> +        The cheap fix is to ensure WKWebView is already the firstResponder when the window is activated. Then NSWindow won't
> +        try to change the firstResponder in response to activation.

Regression test?
Comment 4 Jer Noble 2020-08-24 16:25:43 PDT
Created attachment 407148 [details]
Patch for landing
Comment 5 EWS 2020-08-25 11:08:01 PDT
Committed r266134: <https://trac.webkit.org/changeset/266134>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407148 [details].