| Summary: | WebSocketChannel::didClose should correctly compute whether a closing handshake was received | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=215679 | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2020-08-19 05:15:24 PDT
Created attachment 406840 [details]
Patch
Comment on attachment 406840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review > Source/WebKit/ChangeLog:8 > + Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled. Where is that code path enabled? Why aren’t we seeing the failure in any bot? Comment on attachment 406840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review >> Source/WebKit/ChangeLog:8 >> + Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled. > > Where is that code path enabled? Why aren’t we seeing the failure in any bot? This code path is off by default on all bots. It can be enabled in Safari as an experimental feature. We are working on reducing the test results between the two code paths before enabling this code path. Committed r265856: <https://trac.webkit.org/changeset/265856> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406840 [details]. |