Bug 215638

Summary:	REGRESSION(r265814) [GTK][WPE] Some socket/hybi failures
Product:	WebKit	Reporter:	Lauro Moura <lmoura>
Component:	WebKit Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	achristensen, bugs-noreply, youennf
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=215759

Description Lauro Moura 2020-08-18 20:57:05 PDT

* http/tests/websocket/tests/hybi/invalid-continuation.html

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/websocket/tests/hybi/invalid-continuation-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/websocket/tests/hybi/invalid-continuation-actual.txt
@@ -4,6 +4,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 onopen() was called.
+FAIL onmessage() was called. (message = "Valid frame after closing should be disposed.")
 onclose() was called.
 PASS closeEvent.wasClean is false
 PASS successfullyParsed is true

And

* http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler-actual.txt
@@ -1,15 +1,3 @@
-Tests that WebSocket correctly handles being stopped in the error event handler upon restoring from PageCache.
+CONSOLE MESSAGE: Received invalid WebSocket response from the server
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-pageshow - not from cache
-pagehide - entering cache
-pageshow - from cache
-PASS Page did enter and was restored from the page cache
-error event fired
-PASS wasRestoredFromPageCache is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-

Comment 1 Lauro Moura 2020-08-23 12:59:30 PDT

(In reply to Lauro Moura from comment #0)
> 
> * http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html
> 
> +CONSOLE MESSAGE: Received invalid WebSocket response from the server

This message is related to 0 being passed as closing code in WebSocketChannel::fail(reason) (invoked when suspending due to BackForwardCache).

Soup debug messages:

(process:48): libsoup-DEBUG: 12:35:49.116: Wrong closing code 0 received
(process:48): libsoup-DEBUG: 12:35:49.116: requesting close due to error
(process:48): libsoup-DEBUG: 12:35:49.116: sent frame
(process:48): libsoup-DEBUG: 12:35:49.116: waiting 5 seconds for peer to close io
(process:48): libsoup-DEBUG: 12:35:49.116: queued 8 frame of len 8
(process:48): libsoup-DEBUG: 12:35:49.117: stopping input source
(process:48): libsoup-DEBUG: 12:35:49.117: received control frame 8 with 2 payload
(process:48): libsoup-DEBUG: 12:35:49.117: stopping input source
(process:48): libsoup-DEBUG: 12:35:49.117: peer has closed socket
(process:48): libsoup-DEBUG: 12:35:49.117: closing io stream
(process:48): libsoup-DEBUG: 12:35:49.117: closed: completed io stream close
CONSOLE MESSAGE: WebSocket connection to 'ws://127.0.0.1:8880/websocket/tests/hybi/echo' failed: WebSocket is closed due to suspension.
CONSOLE MESSAGE: WebSocket connection to 'ws://127.0.0.1:8880/websocket/tests/hybi/echo' failed: Received invalid WebSocket response from the server