Bug 215628

Summary:

[webkitpy] Adopt webkitcorepy's OutputCapture

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, cdumez, dewei_zhu, ews-watchlist, glenn, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=215380

Attachments:

Description	Flags
Patch	none

Description Jonathan Bedard 2020-08-18 14:35:46 PDT

Now that OutputCapture has been moved from webkitpy to webkitcorepy, we should remove the one in webkitpy and refactor our testing code so that we use the more modern idioms of the webkitcorepy version of OutputCapture.

Comment 1 Radar WebKit Bug Importer 2020-08-18 14:36:14 PDT

<rdar://problem/67353710>

Comment 2 Jonathan Bedard 2020-08-18 14:41:10 PDT

Created attachment 406812 [details]
Patch

Comment 3 Jonathan Bedard 2020-08-18 14:42:53 PDT

Comment on attachment 406812 [details]
Patch

All about unifying OutputCapture idioms and removing unused code.

There are many individual changes here, but they're all essentially the same thing: use OutputCapture as a decorator, compare stdout/stderr and logs explicitly.

Comment 4 EWS 2020-08-19 11:35:19 PDT

Committed r265883: <https://trac.webkit.org/changeset/265883>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406812 [details].