| Summary: | WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=215640 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2020-08-18 14:27:30 PDT
Created attachment 406811 [details]
Patch
Comment on attachment 406811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406811&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:397 > + if (negotiatedLegacyTLS == NegotiatedLegacyTLS::Yes > + && fastServerTrustEvaluationEnabled > + && !isTopLevelNavigation()) > + return completionHandler(AuthenticationChallengeDisposition::Cancel, { }); Why not do this in NetworkSessionCocoa::continueDidReceiveChallenge rather than passing more state through? Created attachment 406813 [details]
Patch
Comment on attachment 406813 [details]
Patch
Great idea!
Committed r265835: <https://trac.webkit.org/changeset/265835> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406813 [details]. |