| Summary: | ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | clark_wang, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 212611 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2020-08-18 13:50:14 PDT
Created attachment 406808 [details]
Patch
Comment on attachment 406808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406808&action=review > Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:214 > + // De-reference to match the ref() call in process(). Nit: it is a little odd to have this comment only on the second `deref()` Created attachment 406816 [details]
Patch
Committed r265836: <https://trac.webkit.org/changeset/265836> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406816 [details]. |