Bug 215554

Summary: JSDOMConstructorNotConstructable should be a constructor
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch
none
Patch none

Description Yusuke Suzuki 2020-08-16 17:07:49 PDT 
JSDOMConstructorNotConstructable should be a constructor
Comment 1 Yusuke Suzuki 2020-08-16 17:08:29 PDT 
Created attachment 406690 [details]
Patch
Comment 2 Yusuke Suzuki 2020-08-16 17:08:31 PDT 
<rdar://problem/65770688>
Comment 3 Yusuke Suzuki 2020-08-16 17:12:37 PDT 
Created attachment 406691 [details]
Patch
Comment 4 Darin Adler 2020-08-16 17:18:49 PDT 
Comment on attachment 406691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406691&action=review

> LayoutTests/ChangeLog:10
> +        * js/dom/window-is-constructor-expected.txt: Added.
> +        * js/dom/window-is-constructor.html: Added.

Should this be in WPT instead?
Comment 5 Yusuke Suzuki 2020-08-16 22:37:11 PDT 
Comment on attachment 406691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406691&action=review

>> LayoutTests/ChangeLog:10
>> +        * js/dom/window-is-constructor.html: Added.
> 
> Should this be in WPT instead?

Sounds good.
Comment 6 Yusuke Suzuki 2020-08-16 22:38:46 PDT 
Created attachment 406698 [details]
Patch

Collecting updated expected files
Comment 7 Yusuke Suzuki 2020-08-16 23:30:26 PDT 
Created attachment 406699 [details]
Patch

Collecting updated expected files
Comment 8 Yusuke Suzuki 2020-08-17 00:37:19 PDT 
Committed r265749: <https://trac.webkit.org/changeset/265749>