Bug 215544

Summary: Use more enum classes in DateComponents
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, mifenton, pdr, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Rob Buis 2020-08-15 13:06:48 PDT 
Make Type and SecondFormat enum classes since this is more readable
and allows us to have less includes in header files.
Comment 1 Rob Buis 2020-08-15 13:38:00 PDT 
Created attachment 406674 [details]
Patch
Comment 2 Rob Buis 2020-08-15 13:55:52 PDT 
Created attachment 406675 [details]
Patch
Comment 3 Darin Adler 2020-08-15 14:24:22 PDT 
Comment on attachment 406675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406675&action=review

> Source/WebCore/platform/DateComponents.h:39
> +enum class SecondFormat {

I suggest adding ": uint8_t".

> Source/WebCore/platform/DateComponents.h:45
> +enum class DateComponentsType {

I suggest adding ": uint8_t".
Comment 4 Rob Buis 2020-08-16 05:33:15 PDT 
Created attachment 406683 [details]
Patch
Comment 5 Rob Buis 2020-08-16 12:40:45 PDT 
Comment on attachment 406675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406675&action=review

>> Source/WebCore/platform/DateComponents.h:39
>> +enum class SecondFormat {
> 
> I suggest adding ": uint8_t".

Done.

>> Source/WebCore/platform/DateComponents.h:45
>> +enum class DateComponentsType {
> 
> I suggest adding ": uint8_t".

Done.
Comment 6 Radar WebKit Bug Importer 2020-08-22 13:07:16 PDT 
<rdar://problem/67622319>
Comment 7 EWS 2020-08-25 08:29:17 PDT 
Committed r266114: <https://trac.webkit.org/changeset/266114>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406683 [details].