Bug 215534

Summary:

[webkitcorepy] Autoinstaller is very slow in git-svn checkouts

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, dean_johnson, dewei_zhu, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=214378

Attachments:

Description	Flags
Patch	none

Description Jonathan Bedard 2020-08-14 22:05:00 PDT

Worked for a bit debugging this issue today, and while we never got to the root cause, we did get enough information to determine how to avoid such slowness, which is to avoid running setup.py from a directory in a git-svn checkout.

Comment 1 Radar WebKit Bug Importer 2020-08-14 22:05:18 PDT

<rdar://problem/67120623>

Comment 2 Jonathan Bedard 2020-08-14 22:09:42 PDT

Created attachment 406656 [details]
Patch

Comment 3 Jonathan Bedard 2020-08-14 22:11:21 PDT

Comment on attachment 406656 [details]
Patch

Waiting for Dean, who originally reported the issue with his configuration, to verify this actually fixes things for him.

Comment 4 Jonathan Bedard 2020-08-17 11:43:56 PDT

(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 406656 [details]
> Patch
> 
> Waiting for Dean, who originally reported the issue with his configuration,
> to verify this actually fixes things for him.

Dean verified that this fixed his issue. Seems like setup.py doesn't like running from git-svn checkouts.

Comment 5 Dean Johnson 2020-08-17 12:03:52 PDT

Comment on attachment 406656 [details]
Patch

Unofficial r+; fixes my issue and code / ChangeLog looks good.

Comment 6 EWS 2020-08-17 12:29:06 PDT

Committed r265766: <https://trac.webkit.org/changeset/265766>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406656 [details].