| Summary: | [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, fmalita, gyuyoung.kim, pdr, sabouhallawa, schenney, sergio, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2020-08-14 18:48:40 PDT
Created attachment 406647 [details]
Patch
Comment on attachment 406647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406647&action=review > Source/WebCore/svg/graphics/SVGImage.cpp:175 > + return IntSize(300, 150); Are these values used elsewhere? Is it worth using constants or a specific routine to document/centralize these values? Comment on attachment 406647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406647&action=review >> Source/WebCore/svg/graphics/SVGImage.cpp:175 >> + return IntSize(300, 150); > > Are these values used elsewhere? Is it worth using constants or a specific routine to document/centralize these values? They are probably used in a bunch of spots, yeah. We could make a constant. Committed r265742: <https://trac.webkit.org/changeset/265742> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406647 [details]. |