Bug 215528

Summary: [JSC] attribute-change transition should not pin Structure
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
saam: review+
Patch none

Description Yusuke Suzuki 2020-08-14 17:40:43 PDT 
[JSC] attribute-change transition should not pin Structure
Comment 1 Yusuke Suzuki 2020-08-14 17:41:00 PDT 
Created attachment 406637 [details]
Patch
Comment 2 Yusuke Suzuki 2020-08-14 17:51:08 PDT 
Created attachment 406639 [details]
Patch
Comment 3 Yusuke Suzuki 2020-08-14 19:20:01 PDT 
Created attachment 406648 [details]
Patch
Comment 4 Yusuke Suzuki 2020-08-14 19:23:18 PDT 
Created attachment 406649 [details]
Patch
Comment 5 Saam Barati 2020-08-14 19:35:59 PDT 
Comment on attachment 406649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406649&action=review

> Source/JavaScriptCore/runtime/Structure.cpp:492
> +    if (structure->hasBeenDictionary())

maybe just an explanation why this is the way  it is and why it's not profitable to do the other thing
Comment 6 Yusuke Suzuki 2020-08-14 20:23:48 PDT 
Created attachment 406653 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2020-08-21 17:41:13 PDT 
<rdar://problem/67591477>
Comment 8 Yusuke Suzuki 2020-09-11 20:28:18 PDT 
Committed r266969: <https://trac.webkit.org/changeset/266969>