| Summary: | Live Web Content processes do not respect accent color if dynamically changed to "multicolor" | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, ggaren, megan_gardner, pvollan, webkit-bug-importer, wenson_hsieh | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Tim Horton
2020-08-14 14:36:27 PDT
Created attachment 406622 [details]
Patch
Comment on attachment 406622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406622&action=review > Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:80 > + if (!a && !b) > + return true; > + return a && [a isEqual:b]; Nit - I have an ever-so-slight preference for `a == b || [a isEqual:b]`, instead of having a separate branch. Per Arne kindly pointed out that he added a testing mechanism for this, so I'm writing a test. Created attachment 406633 [details]
Patch
Oh dear, the new test passes for me but not the bots. Created attachment 406640 [details]
test logging
Created attachment 406676 [details]
test logging
Created attachment 406677 [details]
Patch
Committed r265740: <https://trac.webkit.org/changeset/265740> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406677 [details]. |