| Summary: | RenderTextControlSingleLine::scroll* functions should not call Element::scroll* on the inner text element | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mifenton, mmaxfield, pdr, simon.fraser, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-08-14 10:51:38 PDT
Created attachment 406625 [details]
Patch
Comment on attachment 406625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406625&action=review > Source/WebCore/ChangeLog:10 > + The clients of these functions expect the geometry data to be inline with the rest of the rendering context in-line or "agree with"? "inline" here confusing in this context. Comment on attachment 406625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406625&action=review >> Source/WebCore/ChangeLog:10 >> + The clients of these functions expect the geometry data to be inline with the rest of the rendering context > > in-line or "agree with"? "inline" here confusing in this context. Could use the word "consistent" Created attachment 406626 [details]
Patch
Comment on attachment 406626 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406626&action=review > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:360 > + if (auto innerTextElement = this->innerTextElement(); innerTextElement && innerTextElement->renderer()) Wow, didn’t know about this syntax! (In reply to Darin Adler from comment #6) > Comment on attachment 406626 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406626&action=review > > > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:360 > > + if (auto innerTextElement = this->innerTextElement(); innerTextElement && innerTextElement->renderer()) > > Wow, didn’t know about this syntax! I discovered it a couple of months ago and been using it heavily ever since. It's super convenient (and the "discovered" part most likely went like: 1. me looking at Antti's patch. 2. wow, didn't know about this syntax!) Committed r265722: <https://trac.webkit.org/changeset/265722> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406626 [details]. |