| Summary: | WritableStream rejected promises should be marked as handled as per spec | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, benjamin, calvaris, darin, ews-watchlist, ggaren, joepeck, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2020-08-14 06:53:36 PDT
Created attachment 406589 [details]
Patch
Comment on attachment 406589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406589&action=review > Source/WebCore/Modules/streams/WritableStreamInternals.js:72 > + @putPromiseInternalField(readyPromiseCapability.@promise, @promiseFieldFlags, @getPromiseInternalField(readyPromiseCapability.@promise, @promiseFieldFlags) | @promiseFlagsIsHandled); Frustrating that this long line of code is repeated 6 times. Is there a way to do this that is less wordy and repetitive, but is also still efficient? Agreed, it would be nice to be able to mirror specs saying 'Set promise.[[PromiseIsHandled]] to true.' I guess adding a builtin for that would probably not be a perf issue. Or we could just introduce a PromiseIsHandled slot. Any thoughts, Yusuke? Tools/Scripts/svn-apply failed to apply attachment 406589 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Will land the patch and will do a follow-up for PromiseIsHandled. Created attachment 406668 [details]
Patch for landing
Committed r265732: <https://trac.webkit.org/changeset/265732> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406668 [details]. |