Bug 215494

Summary: Web Inspector: Assertion Failed: Appended a string with newlines. This breaks the source map.
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Devin Rousso 2020-08-13 23:39:39 PDT
# STEPS TO REPRODUCE
1. inspect any page with C-style comments
Comment 1 Devin Rousso 2020-08-13 23:42:53 PDT
Created attachment 406574 [details]
Patch
Comment 2 Joseph Pecoraro 2020-08-14 10:50:08 PDT
Comment on attachment 406574 [details]
Patch

We should have a test for this, no?
Comment 3 Devin Rousso 2020-08-14 15:15:14 PDT
(In reply to Joseph Pecoraro from comment #2)
> Comment on attachment 406574 [details]
> Patch
> 
> We should have a test for this, no?

We have formatting tests that cover this case, but not source map tests.  I'll add one.
Comment 4 Devin Rousso 2020-08-14 15:31:58 PDT
Created attachment 406628 [details]
Patch
Comment 5 Joseph Pecoraro 2020-08-14 16:21:32 PDT
Comment on attachment 406628 [details]
Patch

Nice!
Comment 6 Devin Rousso 2020-08-14 16:53:01 PDT
Created attachment 406635 [details]
Patch
Comment 7 EWS 2020-08-14 18:24:07 PDT
Committed r265724: <https://trac.webkit.org/changeset/265724>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406635 [details].
Comment 8 Radar WebKit Bug Importer 2020-08-14 18:25:18 PDT
<rdar://problem/67111999>