Bug 215491

Summary:

REGRESSION (r259184): Typing -- then Return into an email moves the selection by two lines

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, darin, ews-watchlist, megan_gardner, mifenton, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fix the title	none

Description Wenson Hsieh 2020-08-13 21:44:08 PDT

<rdar://problem/66938121>

Comment 1 Wenson Hsieh 2020-08-13 22:23:06 PDT Comment hidden (obsolete)

Created attachment 406571 [details]
Patch

Comment 2 Wenson Hsieh 2020-08-13 22:27:06 PDT

Created attachment 406572 [details]
Fix the title

Comment 3 Darin Adler 2020-08-14 10:33:09 PDT

Comment on attachment 406572 [details]
Fix the title

Thank you for fixing this problem I introduced.

Comment 4 Wenson Hsieh 2020-08-14 10:35:16 PDT

(In reply to Darin Adler from comment #3)
> Comment on attachment 406572 [details]
> Fix the title
> 
> Thank you for fixing this problem I introduced.

Thank you for the review! And also for fixing the broken subrange code :)

Comment 5 EWS 2020-08-14 10:38:10 PDT

Committed r265678: <https://trac.webkit.org/changeset/265678>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406572 [details].