Bug 215457

Summary:

Regression(r265580): apply-watchlist is broken

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, jbedard, ryanhaddad, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-08-13 11:42:48 PDT

r265580 broke apply-watchlist.

e.g.:
https://ews-build.webkit.org/#/builders/21/builds/25487
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 80, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py", line 48, in run
    cc_and_messages = self._tool.watch_list().determine_cc_and_messages(diff)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/memoized.py", line 45, in __call__
    result = self._function(*args)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/host.py", line 108, in watch_list
    return WatchListParser().parse(watch_list_contents)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 70, in parse
    dictionary = self._eval_watch_list(watch_list_contents)
  File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 86, in _eval_watch_list
    return eval(watch_list_contents, {'__builtins__': None}, None)
  File "<string>", line 211
    "WebInspectorTests" {
                        ^
SyntaxError: invalid syntax

Comment 1 Aakash Jain 2020-08-13 11:45:01 PDT

Created attachment 406526 [details]
Patch

Comment 2 Aakash Jain 2020-08-13 11:45:55 PDT

Committed r265616: <https://trac.webkit.org/changeset/265616>

Comment 3 Radar WebKit Bug Importer 2020-08-13 11:46:18 PDT

<rdar://problem/67005950>

Comment 4 Devin Rousso 2020-08-13 11:59:35 PDT

ah crap my bad :(

Comment 5 Aakash Jain 2020-08-13 12:11:26 PDT

Retried all the failed builds at https://ews-build.webkit.org/#/builders/Apply-WatchList-EWS

Comment 6 Simon Fraser (smfr) 2020-08-13 12:43:56 PDT

Should we have style checker syntax-check watchlist, as it does for contributors.json?