Bug 215449

Summary:

[ews] Improve wording for test failure email

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jbedard, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jbedard: review+

Description Aakash Jain 2020-08-13 07:17:23 PDT

Improve wording for test failure emails by EWS.

Comment 1 Aakash Jain 2020-08-13 07:20:15 PDT

Created attachment 406512 [details]
Patch

Comment 2 Jonathan Bedard 2020-08-13 08:45:08 PDT

Comment on attachment 406512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406512&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2159
> +            email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id)

Should we link the patch ID to bugzilla?

Comment 3 Aakash Jain 2020-08-13 08:57:35 PDT

Comment on attachment 406512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406512&action=review

>> Tools/BuildSlaveSupport/ews-build/steps.py:2159
>> +            email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id)
> 
> Should we link the patch ID to bugzilla?

Good idea, let me do that in subsequent patch.

Comment 4 Aakash Jain 2020-08-13 08:59:37 PDT

Committed r265609: <https://trac.webkit.org/changeset/265609>

Comment 5 Radar WebKit Bug Importer 2020-08-13 09:00:26 PDT

<rdar://problem/66994254>

Comment 6 Aakash Jain 2020-08-13 09:34:52 PDT

> > Should we link the patch ID to bugzilla?
> 
> Good idea, let me do that in subsequent patch.
Doing it in Bug 215455.