| Summary: | Move scroll / overflow handling out of RenderLayer | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||||
| Component: | Layout and Rendering | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||
| Severity: | Normal | CC: | aboxhall, annulen, apinheiro, bfulgham, cdumez, cfleizach, changseok, cmarcelo, dmazzoni, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jcraig, jdiggs, kangil.han, kondapallykalyan, mifenton, mkwst, mmaxfield, pdr, ryuan.choi, samuel_white, sergio, simon.fraser, zalan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=60305 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 406501 [details]
Patch
Eww 320k :-( The majority of the patch size is moving methods 1:1, unmodified, from RenderLayer to RenderLayerScrollable. @smfr, would be nice if you could have a look at the general design. I'm open for improvements, as always! Needs some iterations, I likely missed win/ios/mac specific build fixes. Created attachment 406515 [details]
Patch
Created attachment 406545 [details]
Patch
Please dup this bug to 60305 and continue work there. |
Per recent discussions between Igalia / Apple, it would be nice to split up RenderLayer into a lean, base class and a derived class which contains all scroll / overflow handling ("RenderLayerScrollable"). I propose to first move all scroll / overflow handling from RenderLayer to RenderLayerScrollable, and as next step only create RenderLayerScrollable objects if needed -- this should be a performance progression for many scenarios. I'll upload an initial draft patch to discuss the design.