| Summary: | Add settings for Copy WebKit Permalink | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Tools / Tests | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dbates, hi, joepeck, keith_miller, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 215796 | ||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2020-08-12 21:27:55 PDT
Created attachment 406495 [details]
Patch
Comment on attachment 406495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406495&action=review > Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3 > + "include_revision": true, I was tempted to have this default to `false` as it's significantly more performant for me, but I erred on the side of caution in preserving existing functionality. Comment on attachment 406495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406495&action=review Patch looks good. > Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py:38 > +class Settings: Ok as is. Consider inherit from object. >> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3 >> + "include_revision": true, > > I was tempted to have this default to `false` as it's significantly more performant for me, but I erred on the side of caution in preserving existing functionality. 👍 Created attachment 406498 [details]
Patch
Committed r265601: <https://trac.webkit.org/changeset/265601> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406498 [details]. |