| Summary: | Add Copy WebKit Permalink items to Sublime Text command palette | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
| Component: | Tools / Tests | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dbates, hi, joepeck, keith_miller, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 189589 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Devin Rousso
2020-08-12 11:34:27 PDT
Created attachment 406466 [details]
Patch
Comment on attachment 406466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406466&action=review rs=me > Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-commands:3 > + { "caption": "Copy WebKit Permalink", "command": "copy_web_kit_permalink" }, > + { "caption": "Copy WebKit Permalink to Blame", "command": "copy_web_kit_permalink", "args": { "annotate_blame": true } }, What's with the underscores between web and kit? Don't we normally use one word even when not capitalizing? Comment on attachment 406466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406466&action=review >> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-commands:3 >> + { "caption": "Copy WebKit Permalink to Blame", "command": "copy_web_kit_permalink", "args": { "annotate_blame": true } }, > > What's with the underscores between web and kit? Don't we normally use one word even when not capitalizing? I believe Sublime Text snakecases any `sublime_plugin.Command` using capital letters as delimiters. I don't know if it's possible to control over that. FWIW this is what `Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu` does too ¯\_(ツ)_/¯ Committed r265557: <https://trac.webkit.org/changeset/265557> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406466 [details]. |