Bug 215405

Summary:

REGRESSION(r265514) [GTK] AX: Some option-related test failing related to invalid roles

Product:

WebKit

Reporter:

Lauro Moura <lmoura>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

bugs-noreply, crzwdjk, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=175341

Attachments:

Description	Flags
accessibility/canvas-fallback-content.html crash log	none

Description Lauro Moura 2020-08-11 20:59:26 PDT

After r265514, in some cases <option> inside a not([multiple]) select (This container maps to AXComboBox in GTK and AXPopUpButton in Mac) is returning an invalid role. Tests:

accessibility/gtk/caret-browsing-select-focus.html
accessibility/gtk/combobox-descendants-orientation-crash.html 
accessibility/gtk/text-for-range-combo-box.html
accessibility/roles-computedRoleString.html
accessibility/roles-exposed.html
inspector/dom/getAccessibilityPropertiesForNode.html

Comment 1 Radar WebKit Bug Importer 2020-08-11 20:59:40 PDT

<rdar://problem/66882251>

Comment 2 Lauro Moura 2020-08-26 20:50:05 PDT

Created attachment 407372 [details]
accessibility/canvas-fallback-content.html crash log

Three accessibility tests also started crashing with similar backtrace after this revision:

* accessibility/canvas-accessibilitynodeobject.html
* accessibility/canvas-fallback-content-2.html
* accessibility/canvas-fallback-content.html

Sample of backtrace for canvas-fallback-content:

Thread 1 (Thread 0x7fca885262c0 (LWP 372)):
#0  0x00007fca8ebd11ee in WTFCrash () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#1  0x00007fca9236c2cd in WebCore::AccessibilityObject::insertChild(WebCore::AXCoreObject*, unsigned int) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#2  0x00007fca9235821c in WebCore::AccessibilityNodeObject::addChildren() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#3  0x00007fca92351a80 in WebCore::AccessibilityObject::updateChildrenIfNecessary() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#4  0x00007fca9235125c in WebCore::AccessibilityObject::updateBackingStore() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#5  0x00007fca9238ace9 in webkitAccessibleGetRole(_AtkObject*) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#6  0x00007fca44bacacf in WTR::(anonymous namespace)::roleToString(_AtkObject*) () at /app/webkit/WebKitBuild/Release/lib/libTestRunnerInjectedBundle.so
#7  0x00007fca44bae349 in WTR::AccessibilityUIElement::role() () at /app/webkit/WebKitBuild/Release/lib/libTestRunnerInjectedBundle.so
#8  0x00007fca44b9447f in WTR::JSAccessibilityUIElement::role(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSString*, OpaqueJSValue const**) () at /app/webkit/WebKitBuild/Release/lib/libTestRunnerInjectedBundle.so
#9  0x00007fca8dc6e37b in JSC::JSCallbackObject<JSC::JSNonFinalObject>::getStaticValue(JSC::JSGlobalObject*, JSC::PropertyName) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#10 0x00007fca8dc6e932 in JSC::JSCallbackObject<JSC::JSNonFinalObject>::getOwnPropertySlot(JSC::JSObject*, JSC::JSGlobalObject*, JSC::PropertyName, JSC::PropertySlot&) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#11 0x00007fca8e5d7046 in JSC::LLInt::performLLIntGetByID(JSC::Instruction const*, JSC::CodeBlock*, JSC::JSGlobalObject*, JSC::JSValue, JSC::Identifier const&, JSC::GetByIdModeMetadata&) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#12 0x00007fca8e5d7a3b in llint_slow_path_get_by_id () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#13 0x00007fca8dbd510f in llint_op_get_by_id () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#14 0x0000000000000000 in  ()

Comment 3 Arcady Goldmints-Orlov 2021-10-25 11:31:41 PDT

The following 2 tests no longer fail as of r284760:

accessibility/gtk/caret-browsing-select-focus.html
accessibility/gtk/combobox-descendants-orientation-crash.html