Bug 215394

Summary: Address locking concerns and other review feedback from r265502
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED WONTFIX    
Severity: Normal CC: darin, dino, jdarpinian, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 214765    
Bug Blocks:    

Description Kenneth Russell 2020-08-11 14:46:04 PDT
ysuzuki@ provided review feedback for Bug 214765 after the patch was landed which needs to be addressed.

The most significant concern is that locking is needed around some object traversals since GC marking can occur concurrently to the main thread. However, these objects represent a tree structure and it's not immediately clear how to organize such a lock.
Comment 1 Kenneth Russell 2020-08-11 15:05:16 PDT
Reverted the patch because of the potential for multithreading-related GC craghes. Will address this feedback in the parent bug.