Bug 215370

Summary: Add JS console log message in case of capture failure
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hi, hta, jer.noble, mkwst, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2020-08-11 05:53:07 PDT 
Add JS console log message in case of capture failure
Comment 1 youenn fablet 2020-08-11 05:59:15 PDT 
Created attachment 406376 [details]
Patch
Comment 2 Eric Carlson 2020-08-11 07:14:05 PDT 
Comment on attachment 406376 [details]
Patch

Thanks!
Comment 3 EWS 2020-08-11 10:07:35 PDT 
Committed r265501: <https://trac.webkit.org/changeset/265501>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406376 [details].
Comment 4 Radar WebKit Bug Importer 2020-08-11 10:08:16 PDT 
<rdar://problem/66846429>
Comment 5 Devin Rousso 2020-08-14 13:51:33 PDT 
Comment on attachment 406376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406376&action=review

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:539
> +        scriptExecutionContext()->addConsoleMessage(MessageSource::JS, MessageLevel::Error, "A MediaStreamTrack ended due to a capture failure"_s);

For future reference, this probably should've used `MessageSource::Media` or `MessageSource::MediaStream`.

`MessageSource::JS` is supposed to be for "this comes from JavaScript language logic".