Bug 215358

Summary:

Consider changing ScriptExecutable::prepareForExecution() to return a CodeBlock*.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

ASSIGNED ---

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=215357

Attachments:

Description	Flags
proposed patch.	none

Description Mark Lam 2020-08-10 22:44:23 PDT

There's no need to return an Exception*.  The canonical way to get the Exception* is from a ThrowScope.

This non-canonical idiom of returning an Exception* here can result in bugs e.g. https://bugs.webkit.org/show_bug.cgi?id=215357.

Comment 1 Mark Lam 2020-08-10 22:55:58 PDT Comment hidden (obsolete)

Created attachment 406362 [details]
proposed patch.

Comment 2 Mark Lam 2020-08-10 23:00:12 PDT Comment hidden (obsolete)

Comment on attachment 406362 [details]
proposed patch.

Submitted patch to wrong bug.  Sorry.

Comment 3 Radar WebKit Bug Importer 2020-08-17 22:45:14 PDT

<rdar://problem/67298086>