Bug 215341

Summary: AuxiliaryProcess::didReceiveInvalidMessage() for WebPage::PerformDragControllerAction IPC
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ddkilzer, ggaren, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213093, 215349    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2020-08-10 15:46:20 PDT 
AuxiliaryProcess::didReceiveInvalidMessage() for WebPage::PerformDragControllerAction IPC.
Comment 1 Chris Dumez 2020-08-10 15:46:33 PDT 
<rdar://problem/59344091>
Comment 2 Chris Dumez 2020-08-10 16:06:53 PDT 
Created attachment 406335 [details]
Patch
Comment 3 Chris Dumez 2020-08-10 16:11:44 PDT 
Created attachment 406339 [details]
Patch
Comment 4 Chris Dumez 2020-08-10 16:17:38 PDT 
Created attachment 406341 [details]
Patch
Comment 5 Chris Dumez 2020-08-10 16:19:48 PDT 
Working on getting GTK/WPE building
Comment 6 Wenson Hsieh 2020-08-10 16:33:05 PDT 
Comment on attachment 406341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406341&action=review

> Tools/TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:151
> +    return [NSEvent mouseEventWithType:NSEventTypeLeftMouseDragged
> +                location:NSMakePoint(0, 200)
> +           modifierFlags:NSEventModifierFlagOption
> +               timestamp:[NSDate timeIntervalSinceReferenceDate]
> +            windowNumber:0
> +                 context:nil
> +             eventNumber:1
> +              clickCount:1
> +                pressure:1];

(Minor style nit - we should either make this all 1 line, or left align all the parameters)
Comment 7 Chris Dumez 2020-08-10 16:36:01 PDT 
Created attachment 406344 [details]
Patch
Comment 8 David Kilzer (:ddkilzer) 2020-08-10 16:42:58 PDT 
Comment on attachment 406344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406344&action=review

> Source/WebCore/platform/DragData.h:62
>      DragApplicationNone = 0,

Darin insisted I remove the "None" enums when switching to use OptionSet<>.  We don't need to do that for this patch, but I'll look at doing it as a follow-up (and covert DragApplicationFlags to an enum class).
Comment 9 Chris Dumez 2020-08-10 16:46:07 PDT 
Created attachment 406345 [details]
Patch
Comment 10 EWS 2020-08-10 17:26:12 PDT 
Committed r265480: <https://trac.webkit.org/changeset/265480>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406345 [details].