| Summary: | Shaping can be performed on glyphIDs from the wrong font | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, dino, jonlee, simon.fraser, thorton, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 206208, 215059 | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2020-08-10 13:01:19 PDT
Created attachment 406322 [details]
Patch
Comment on attachment 406322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406322&action=review > Source/WebCore/platform/graphics/WidthIterator.cpp:181 > + const GlyphData& uppercaseGlyphData = m_font.glyphDataForCharacter(u_toupper(character), m_run.rtl()); I suggest we use "auto&" here and/or have the local variable be the font instead of the glyph data: auto glyphFont = m_font.glyphDataForCharacter(u_toupper(character), m_run.rtl()).font; Committed r265455: <https://trac.webkit.org/changeset/265455> |