| Summary: | Off by one error in transform feedback buffer binding | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||
| Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 126404 | ||||||
| Attachments: |
|
||||||
|
Description
James Darpinian
2020-08-07 16:04:06 PDT
Created attachment 406224 [details]
Patch
Comment on attachment 406224 [details]
Patch
Looks good to me. I'd r+ but my reviewer status hasn't been reinstated.
Comment on attachment 406224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review > Source/WebCore/ChangeLog:8 > + Caught by conformance test deqp/functional/gles3/negativebufferapi.html This change is missing a test. Comment on attachment 406224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review >> Source/WebCore/ChangeLog:8 >> + Caught by conformance test deqp/functional/gles3/negativebufferapi.html > > This change is missing a test. The test is present. The suite it's in (deqp) is currently skipped in the test expectations because it takes a long time to run. I'm looking into whether we can make it faster. Comment on attachment 406224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review >>> Source/WebCore/ChangeLog:8 >>> + Caught by conformance test deqp/functional/gles3/negativebufferapi.html >> >> This change is missing a test. > > The test is present. The suite it's in (deqp) is currently skipped in the test expectations because it takes a long time to run. I'm looking into whether we can make it faster. We have a separate bot that runs the deqp tests. Committed r265399: <https://trac.webkit.org/changeset/265399> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406224 [details]. |