| Summary: | AudioContext / OfflineAudioContext should support a wider sample rate range | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | calvaris, clark_wang, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, pnormand, sergio, vjaquez, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 212611, 215301 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Chris Dumez
2020-08-07 13:11:26 PDT
Created attachment 406211 [details]
Patch
Comment on attachment 406211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406211&action=review > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:108 > bool BaseAudioContext::isSampleRateRangeGood(float sampleRate) This isn't new, but`isSampleRateRangeGood` isn't a great name. What is a "good" sample rate, one that renders natively, or one that sounds good, or ... `isSampleRateSupported` or `isSupportedSampleRate` would be a better name. Created attachment 406215 [details]
Patch
Created attachment 406217 [details]
Patch
Created attachment 406220 [details]
Patch
Created attachment 406225 [details]
Patch
Created attachment 406230 [details]
Patch
Committed r265403: <https://trac.webkit.org/changeset/265403> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406230 [details]. |