| Summary: | We should run the tests for DataMutex | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||||
| Component: | Web Template Framework | Assignee: | Robin Morisset <rmorisset> | ||||||||
| Status: | RESOLVED WONTFIX | ||||||||||
| Severity: | Normal | CC: | mark.lam | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Robin Morisset
2020-08-07 06:41:43 PDT
Created attachment 406169 [details]
Patch
Created attachment 406173 [details]
Patch
rebased
Comment on attachment 406173 [details]
Patch
r- for now. Can you look into why the EWS bots are red?
Created attachment 406287 [details]
Patch
The EWS were red because some of our platforms don't support gtests'ASSERT_DEATH.
I made the tests that depend on this macro conditional on its support.
Comment on attachment 406287 [details]
Patch
Thanks for fixing the failures. Unfortunately, I don't think we should land this because grepping the code, I see that the DataMutex class is only used by the gtk port. Unless we have a reason to include it (e.g. pending use), we should leave it out for Darwin ports. You can close this bug as WONTFIX.
Ok. |