Bug 215265

Summary: We should run the tests for DataMutex
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: Web Template FrameworkAssignee: Robin Morisset <rmorisset>
Status: RESOLVED WONTFIX    
Severity: Normal CC: mark.lam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mark.lam: review-
Patch mark.lam: review-, mark.lam: commit-queue-

Robin Morisset
Reported 2020-08-07 06:41:43 PDT
Tools/TestWebkitAPI/Tests/WTF/DataMutex.cpp exists, but it is not included in the building of the testWTF binary, and as a result is never run. Fixing it is trivial.
Attachments
Patch (4.12 KB, patch)
2020-08-07 06:43 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (4.18 KB, patch)
2020-08-07 07:36 PDT, Robin Morisset 		mark.lam: review-
DetailsFormatted DiffDiff
Patch (5.06 KB, patch)
2020-08-10 01:45 PDT, Robin Morisset 		mark.lam: review-
mark.lam: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2020-08-07 06:43:02 PDT
Created attachment 406169 [details] Patch
Robin Morisset
Comment 2 2020-08-07 07:36:49 PDT
Created attachment 406173 [details] Patch rebased
Mark Lam
Comment 3 2020-08-08 00:19:40 PDT
Comment on attachment 406173 [details] Patch r- for now. Can you look into why the EWS bots are red?
Robin Morisset
Comment 4 2020-08-10 01:45:44 PDT
Created attachment 406287 [details] Patch The EWS were red because some of our platforms don't support gtests'ASSERT_DEATH. I made the tests that depend on this macro conditional on its support.
Mark Lam
Comment 5 2020-08-10 06:58:43 PDT
Comment on attachment 406287 [details] Patch Thanks for fixing the failures. Unfortunately, I don't think we should land this because grepping the code, I see that the DataMutex class is only used by the gtk port. Unless we have a reason to include it (e.g. pending use), we should leave it out for Darwin ports. You can close this bug as WONTFIX.
Robin Morisset
Comment 6 2020-08-10 11:20:28 PDT
Ok.
Note You need to log in before you can comment on or make changes to this bug.