| Summary: | [GStreamer] gst-full standalone library support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, berto, calvaris, cgarcia, clopez, eric.carlson, ews-watchlist, glenn, gustavo, gyuyoung.kim, jer.noble, menard, philipj, ryuan.choi, sergio, vjaquez, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2020-08-07 02:11:31 PDT
Created attachment 406162 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 406163 [details]
Patch
Comment on attachment 406163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406163&action=review > Source/WebKit/UIProcess/gstreamer/WebPageProxyGStreamer.cpp:45 > +#if !USE(GSTREAMER_FULL) > auto request = InstallMissingMediaPluginsPermissionRequest::create(*this, details, description); > if (pageClient().decidePolicyForInstallMissingMediaPluginsPermissionRequest(request.get())) > return; > > request->deny(); > +#endif #else UNUSED_PARAM... > Tools/ChangeLog:8 > + Disable GStreamer options command-line support in MiniBrowsers. This isn't very useful and State that this is a non-related clean-up or move it to a different patch, please. Committed r265492: <https://trac.webkit.org/changeset/265492> |