Bug 215251

Summary: Pocket City game play area is blank (WebGL is broken in Catalyst)
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, graouts, kondapallykalyan, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Dean Jackson 2020-08-06 18:38:40 PDT 
Pocket City game play area is blank (WebGL is broken in Catalyst)
Comment 1 Dean Jackson 2020-08-06 18:39:31 PDT 
<rdar://63699436>
Comment 2 Dean Jackson 2020-08-06 18:42:42 PDT 
Created attachment 406146 [details]
Patch
Comment 3 Dean Jackson 2020-08-07 02:29:10 PDT 
Committed r265366: <https://trac.webkit.org/changeset/265366>
Comment 4 Darin Adler 2020-08-07 15:57:49 PDT 
Comment on attachment 406146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406146&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:404
> +#if PLATFORM(MAC)

I suggest we try to avoid unnecessary #if nesting. Here we could have done an #endif above, then would not need two different #else below.
Comment 5 Dean Jackson 2020-08-13 15:58:04 PDT 
Fixed. Thanks Darin.
Comment 6 Dean Jackson 2020-08-13 15:59:40 PDT 
Committed r265635: <https://trac.webkit.org/changeset/265635>