| Summary: | [WebXR] Update WebXR WPT directory | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, aperez, cgarcia, clopez, darin, dino, ews-watchlist, svillar, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 208988 | ||||||
| Attachments: |
|
||||||
|
Description
Sergio Villar Senin
2020-08-06 10:15:45 PDT
Created attachment 406090 [details]
Patch
Ping reviewers Comment on attachment 406090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406090&action=review > Source/WebCore/Modules/webxr/WebXRInputSourceArray.cpp:41 > +} Could be inline > LayoutTests/imported/w3c/web-platform-tests/webxr/dom-overlay/ar_dom_overlay.https.html:139 > + debug('got viewerSpace'); Is it expected logging? > LayoutTests/imported/w3c/web-platform-tests/webxr/dom-overlay/ar_dom_overlay.https.html:206 > + debug('got rAF 1'); Ditto. Comment on attachment 406090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406090&action=review Thanks for the review! >> Source/WebCore/Modules/webxr/WebXRInputSourceArray.cpp:41 >> +} > > Could be inline OK. I'll move it. >> LayoutTests/imported/w3c/web-platform-tests/webxr/dom-overlay/ar_dom_overlay.https.html:139 >> + debug('got viewerSpace'); > > Is it expected logging? This come straight from upstream. In our case it does not matter much because the debug() call is only implemented by Chromium AFAIK. For the rest of engines is an empty implementation. But I agree that it's weird to upstream something with debug statements. Committed r265546: <https://trac.webkit.org/changeset/265546> |